-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cpn unfolding - fix 2081147 #174
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice cleanup of the code.
The fix looks correct - I am unsure if it fixes the more general problem.
The subtraction change looks a little funky.
…ts a tuple including a var
... but other than my comments, a nice change. I have a hard time to determine if this fixes all the issues. But it has the right flavor to it (i.e. more general/relaxed in assumption about the structure of the colors). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes the bug and passes all the consistency and performance checks.
Fixes:
https://bugs.launchpad.net/tapaal/+bug/2081147
By adding a extra empty map if right most expr is a VariableExpression or a tuple expression with a VariableExpression